Font Library: Store font subdirectory in post meta.

[peterwilsoncc]

What?

Stores the font file sub-directory in the wp_font_face post meta. Similar to attachments, only the portion of the path relative to the base directory is stored.

Why?

This ensures the files can be deleted alongside their post on sites using a plugin to store font files in sub-directories. Previously running such a plugin would result in the files remaining on the file system post delete.

How?

Backports WordPress/wordpress-develop@a033cf1

Testing Instructions

1. Configure site to run on WordPress 6.4 to ensure the font directory is using the Gutenberg settings.
2. Add the mini-plugin below to your mu-plugins folder
3. Upload a font/sideload from Google
4. Observe the font file is stored in a sub-directory
5. Observe the font file's sub-directory is not stored in the post meta
6. Wait 30 seconds for a tick of the mu-plugin
7. Delete the font via the font library
8. Ensure the font file is deleted. (Edited because I initially put the reproduction step here 🤦)
9. Remove the min-plugin from your mu-plugins to avoid confusion later.

Testing mini-plugin:

add_filter( 'font_dir', function ( $font_dir ) {
        /*
         * Change sub-directory every 30 seconds
         *
         * POC only, a more likely use is to get the `fontFamily` from the API
         * request or the currently active theme and use either of those values
         * to generate a unique sub-directory.
         *
         * The POC is simply to allow for easier testing by setting a new
         * sub-directory every 30 seconds.
         */
        $subdir = '/' . (string) floor( time() / 30 );
        $font_dir['subdir'] = $subdir;
        $font_dir['path'] .= $subdir;
        $font_dir['url'] .= $subdir;
        return $font_dir;
} );

Testing Instructions for Keyboard

N/A

Screenshots or screencast

N/A

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org>
Co-authored-by: creativecoder <grantmkin@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[creativecoder]

• ✅ Manually verified changed code matches WordPress/wordpress-develop@a033cf1
• ✅ Tested to make sure font files are correctly deleted even after changing the font_dir filter's subdir value