DataViews: Register the export pattern action like any third-party action #63046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
youknowriad
requested review from
oandregal,
ellatrix,
jorgefilipecosta and
ntsekouras
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +23 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
update/remove-user-pattern-mapping
branch
from
6b5377b
to
0539bc8
Compare
youknowriad
requested review from
nerrad,
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
youknowriad
force-pushed
the
update/export-pattern-action
branch
from
f78ba1f
to
ec7dc4c
Compare
youknowriad
force-pushed
the
update/remove-user-pattern-mapping
branch
from
0539bc8
to
3a65582
Compare
youknowriad
force-pushed
the
update/export-pattern-action
branch
from
ec7dc4c
to
e2abb45
Compare
ntsekouras
reviewed
Jul 4, 2024
ntsekouras
reviewed
Jul 4, 2024
| ...( | ||
| state[ action.kind ]?.[ action.name ] ?? [] | ||
| ).filter( | ||
| ( _action ) => _action.id !== action.config.id |
There was a problem hiding this comment.
Why do we need this filtering? Is it just defensive programming for trying to register the same action twice or was it needed actually for this PR?
There was a problem hiding this comment.
Yes, It's to override the previous action with the same id.
ntsekouras
approved these changes
Jul 4, 2024
|
I can't merge this PR until the parent PR is reviewed #63042 |
youknowriad
force-pushed
the
update/export-pattern-action
branch
from
92de1dd
to
51e975b
Compare
youknowriad
force-pushed
the
update/export-pattern-action
branch
from
51e975b
to
5c1d40e
Compare
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
…tion (WordPress#63046) Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #61084
Similar to #62913
What?
In #62052 an API to register and unregister dataviews actions has been implemented. But in order to allow third-party developers to be able to unregister these actions, we need to be using the same actions in Core to register the core actions.
The current PR explore the possibility to use the API to register one action: "export pattern".
Testing Instructions
1- Open the patterns dataviews
2- Click "My patterns"
3- On the actions menu per pattern, click "Export as JSON"