Group: Update block example #63114
Merged
Group: Update block example #63114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
|
Size Change: +355 B (+0.02%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 37a3310. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9828618068
|
ramonjd
reviewed
Jul 4, 2024
| customTextColor: '#00d084', | ||
| fontSize: 'large', | ||
| content: __( 'Four.' ), | ||
| url: 'https://s.w.org/images/core/5.3/Glacial_lakes%2C_Bhutan.jpg', |
There was a problem hiding this comment.
I don't know if it matters, but maybe we could marry the text with the image?
Lake Bhutan is a high-altitude lake in Bhutan, known for its pristine beauty, clear waters, and serene surroundings, attracting nature lovers and trekkers.
Or, there are some free use images related to Don Quixote over at https://www.oldbookillustrations.com/search/?q=don+quixote
There was a problem hiding this comment.
maybe we could marry the text with the image?
100%. This was my intention and why I left this in draft status 🙂
There was a problem hiding this comment.
It would be nice if all the blocks' example content had some level of consistency or theme. It's pretty random at the moment 😅
| }, | ||
| attributes: { | ||
| layout: { | ||
| type: 'constrained', |
There was a problem hiding this comment.
Simple and looking pretty good.
2024-07-04.19.10.21.mp4
I think this would be a nice follow-up. |
|
I pushed some small tweaks:
|
richtabor
reviewed
Jul 7, 2024
| @@ -4,6 +4,59 @@ | |||
| import { __, _x } from '@wordpress/i18n'; | |||
| import { group, row, stack, grid } from '@wordpress/icons'; | |||
|
|
|||
| const example = { | |||
There was a problem hiding this comment.
Is this example being used at all?
I have a row block here and it's using the current index.js example. Stack and grid are the same.
There was a problem hiding this comment.
It's used for previewing the different block variations in the block inserter.
Steps 5 - 8 in the test instructions cover this aspect. To save you having to fire up the PR locally you can see the original example with the main block inserter from the 30s mark on in the description's demo video.
There was a problem hiding this comment.
This might be easier still 🙂
Screen.Recording.2024-07-29.at.5.10.47.PM.mp4
|
@aaronrobertshaw is anything blocking this? seems like a nice quick update. |
aaronrobertshaw
force-pushed
the
update/group-block-example
branch
from
37a3310
to
3079605
Compare
Only the fact I was waiting on decisions and then the WP 6.6 release caused this to drop down the priority list. If you are happy with the current state of the example in this PR, we can easily merge and iterate further via follow-ups. Someone else may need to pick up the follow-ups as I'll be AFK for a couple of weeks in the near future. I've rebased this PR and flagged it ready for review. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #63035
What?
Updates the inner blocks for the default Group example block while keeping the existing example for the Row, Stack, and Grid block variations.
Alternative to #63039.
Why?
The current example doesn't add a lot of value, especially when a user is attempting to preview block style variations. See #63035
How?
Testing Instructions
Screenshots or screencast
Screen.Recording.2024-07-04.at.5.18.55.PM.mp4
Possible Follow-ups