Tooltip Component: Add custom class name support #63157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
github-actions
bot
added
the
First-time Contributor
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @aliaghdam! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
akasunil
added
[Type] Enhancement
tyxla
reviewed
Jul 5, 2024
There was a problem hiding this comment.
Thanks for your contribution, @aliaghdam 🙌
I've left some suggestions and questions for your consideration, let me know what you think.
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
ciampo
reviewed
Jul 8, 2024
tyxla
reviewed
Jul 8, 2024
There was a problem hiding this comment.
Thanks for addressing all the feedback @aliaghdam 🙌
The PR should be good to go once @ciampo's feedback is addressed.
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com>
ciampo
approved these changes
Jul 8, 2024
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Jul 10, 2024
* feat: custom class name support for Tooltip component * test: add custom class name tests for Tooltip component * chore: changelog update * chore: improve comment * chore: fix string literals Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com> * fix: use clx for classname Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com> * fix: changelog Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com> * fix: merge tests Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com> * fix: import clx * fix: props order * chore: improve test name * fix: changelog * chore: props order * chore: remove empty line Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com> * chore: remove internal class name from prop description. Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com> --------- Co-authored-by: aliaghdam <aliaghdam@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org>
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
* feat: custom class name support for Tooltip component * test: add custom class name tests for Tooltip component * chore: changelog update * chore: improve comment * chore: fix string literals Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com> * fix: use clx for classname Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com> * fix: changelog Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com> * fix: merge tests Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com> * fix: import clx * fix: props order * chore: improve test name * fix: changelog * chore: props order * chore: remove empty line Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com> * chore: remove internal class name from prop description. Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com> --------- Co-authored-by: aliaghdam <aliaghdam@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org>
lipemat
added a commit
to lipemat/types-js-boilerplate
that referenced
this pull request
Aug 21, 2024
fabiankaegy
added
the
Needs Dev Note
97 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The Tooltip component does not supports custom css class name.
Why?
I added the custom class name support that that for many reasons can be used for design customization of tooltip.
How?
I added the
classNameprop and also added test to make sure it works properly.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Unlinked contributors: aliaghdam.