DataViews: add performance test for pages #63170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
the
[Type] Automated Testing
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -19 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in a3dc531. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9805167542
|
youknowriad
reviewed
Jul 5, 2024
|
|
||
| const startTime = performance.now(); | ||
|
|
||
| await page.getByRole( 'button', { name: 'Pages' } ).click(); |
There was a problem hiding this comment.
I wonder if we should be using the "list" view. I think maybe using the "table" view would be better and we could set the url explicitly in the admin.visitSiteEditor call as it's less fragile to changes we might do to the root page of "pages".
There was a problem hiding this comment.
list is also kind of tested in the "navigate" metric.
There was a problem hiding this comment.
Sure I changed it to start with the trash table view then. The reason for this is that we don't want to measure a complete page load.
There was a problem hiding this comment.
list is also kind of tested in the "navigate" metric.
Actually, I just checked this test, and it doesn't test loading the list view, it only tests selecting item from the list after it has loaded.
youknowriad
reviewed
Jul 5, 2024
|
|
||
| await page.getByRole( 'button', { name: 'Pages' } ).click(); | ||
|
|
||
| await Promise.all( |
There was a problem hiding this comment.
What are we waiting for exactly here, can we add a clarifying comment?
There was a problem hiding this comment.
Added one, we are waiting for all pages to load.
youknowriad
approved these changes
Jul 5, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
See #63151.
Adds a performance test for the pages data view (per page = 20, the default). These are just simple pages. Maybe at some point we can add featured images.
Why?
It's easier to get a sense of progress when we're measuring.
How?
See the test's code.
Testing Instructions
There should be an extra entry for
loadPagesis the performance test.Testing Instructions for Keyboard
Screenshots or screencast