Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CustomSelectControl V2 legacy adapter: stabilize experimental props #63248

Merged
merged 13 commits into from
Jul 10, 2024
Merged

CustomSelectControl V2 legacy adapter: stabilize experimental props #63248

merged 13 commits into from
Jul 10, 2024

Commits on Jul 10, 2024

  1. CustomSelectControl V2: add showSelectedHint prop, deprecate __experi… 

    …mentalShowSelectedHint
    @ciampo
    ciampo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    093a1fd View commit details
    Browse the repository at this point in the history

  2. Update showSelectedHint unit tests

    @ciampo
    ciampo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    8bae16c View commit details
    Browse the repository at this point in the history

  3. CustomSelectControl V2: add hint option prop, deprecate __experimenta… 

    …lHint
    @ciampo
    ciampo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    585e566 View commit details
    Browse the repository at this point in the history

  4. Rename __experimentalHint to hint

    @ciampo
    ciampo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    f529ae0 View commit details
    Browse the repository at this point in the history

  5. Refactor to smarter approach

    @ciampo
    ciampo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    2e42cbe View commit details
    Browse the repository at this point in the history

  6. Continue using __experimentalHint in the V1 storybook example

    @ciampo
    ciampo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    b0db404 View commit details
    Browse the repository at this point in the history

  7. CHANGELOG

    @ciampo
    ciampo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    b12ab44 View commit details
    Browse the repository at this point in the history

  8. Add hint to options only if necessary

    @ciampo
    ciampo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    96299c6 View commit details
    Browse the repository at this point in the history

  9. __experimentalShowSelectedHint => showSelectedHint

    @ciampo
    ciampo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    9ad93e5 View commit details
    Browse the repository at this point in the history

  10. Move changelog entry to unreleased section

    @ciampo
    ciampo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    0f127e8 View commit details
    Browse the repository at this point in the history

  11. Give priority to showSelectedHint over `__experimentalShowSelectedH… 

    …int`
    @ciampo
    ciampo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    8e02b5f View commit details
    Browse the repository at this point in the history

  12. Move __experimentalHint => hint code to run at runtime 

    This avoids breakages for any consumer relying on object identity
    @ciampo
    ciampo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    2c98210 View commit details
    Browse the repository at this point in the history

  13. Fix wrong link in inline comment

    @ciampo
    ciampo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    4d118af View commit details
    Browse the repository at this point in the history