In-between inserter: allow scrolling over indicator #63270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -75 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
ellatrix
commented
Jul 8, 2024
|
|
||
| return () => { | ||
| node.removeEventListener( 'mousemove', onMouseMove ); | ||
| node.removeEventListener( 'click', onMouseMove ); |
There was a problem hiding this comment.
This onClick handler was previously in the popover, but we can handled it here since it's now click-through.
ellatrix
commented
Jul 8, 2024
| @@ -30,18 +30,10 @@ | |||
| // drop zone. | |||
| pointer-events: none; | |||
|
|
|||
| * { | |||
| pointer-events: none; | |||
There was a problem hiding this comment.
pointer-events is inherited.
ellatrix
commented
Jul 8, 2024
| nextClientId && | ||
| getBlockEditingMode( nextClientId ) !== 'disabled' | ||
| ) { | ||
| selectBlock( nextClientId, -1 ); |
There was a problem hiding this comment.
As noted above, this has moved to the canvas instead.
ellatrix
commented
Jul 8, 2024
| // Only hide the inserter if it's triggered on the wrapper, | ||
| // and the inserter is not open. | ||
| if ( event.target === ref.current && ! openRef.current ) { | ||
| hideInsertionPoint(); |
There was a problem hiding this comment.
These things seem to be workarounds to the fact that the indicator caught clicks (and didn't trigger the mousemove event listener in the canvas, so it had to be duplicated here.
ellatrix
removed
the
Backport to WP 6.7 Beta/RC
|
It's getting a bit too complex to consider for 6.6. |
Is it possible to reduce it down to just the CSS changes for 6.6 or are all the JS changes required too? I tested and it works, but I'd like a bit more time to understand the JS changes. |
|
@talldan No, not possible unfortunately because by setting pointer events to none, those event handlers will basically never be called. |
|
@ellatrix It'd be good to revisit this one and finally get it fixed. If you want to rebase the PR I'd be happy to give it a test and 👍 if everything's still working. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #63260.
Why?
Because it's super annoying. :)
How?
Looks like pointer-events: all was re-applied to early on the entire indicator instead of just on the button.
Testing Instructions
Hover over the space in between blocks and scroll.
Make sure that #45420 does not regress.
Testing Instructions for Keyboard
Screenshots or screencast