-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.wp-env.json schema: Fix schema and add unit tests #63281
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
/** | ||
* External dependencies | ||
*/ | ||
import Ajv from 'ajv'; | ||
import glob from 'fast-glob'; | ||
|
||
/** | ||
* Internal dependencies | ||
*/ | ||
import wpEnvSchema from '../../schemas/json/wp-env.json'; | ||
|
||
describe( '.wp-env.json schema', () => { | ||
const jsonFiles = glob.sync( [ '.wp-env.json' ], { onlyFiles: true } ); | ||
const ajv = new Ajv( { | ||
allowMatchingProperties: true, | ||
} ); | ||
|
||
test( 'strictly adheres to the draft-07 meta schema', () => { | ||
// Use ajv.compile instead of ajv.validateSchema to validate the schema | ||
// because validateSchema only checks syntax, whereas, compile checks | ||
// if the schema is semantically correct with strict mode. | ||
// See https://github.com/ajv-validator/ajv/issues/1434#issuecomment-822982571 | ||
const result = ajv.compile( wpEnvSchema ); | ||
|
||
expect( result.errors ).toBe( null ); | ||
} ); | ||
|
||
test( 'found .wp-env.json files', () => { | ||
expect( jsonFiles.length ).toBeGreaterThan( 0 ); | ||
} ); | ||
|
||
test.each( jsonFiles )( 'validates schema for `%s`', ( filepath ) => { | ||
// We want to validate the .wp-env.json file using the local schema. | ||
const { $schema, ...metadata } = require( filepath ); | ||
|
||
// we expect the $schema property to be present in the .wp-env.json file | ||
expect( $schema ).toBeTruthy(); | ||
|
||
const result = ajv.validate( wpEnvSchema, metadata ) || ajv.errors; | ||
|
||
expect( result ).toBe( true ); | ||
} ); | ||
} ); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think any new
.wp-env.json
files will be added in the future, but I am concerned that there may be a better pattern.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove the
jsonFiles
array entirely if there's only one..wp-env.json
file just like the schema as an internal dependency.'found .wp-env.json files'
test.test.each
with a singular test.require( filepath )
with the imported variable.