Dataviews List: Update item layout #63299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
46 tasks
|
Size Change: +229 B (+0.01%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Jul 9, 2024
| background: #f8f8f8; | ||
| padding-left: $grid-unit-10; | ||
| margin-right: $grid-unit-30; | ||
| box-shadow: -12px 0 8px 0 #f8f8f8; |
There was a problem hiding this comment.
Can we substitute a few variables here?
There was a problem hiding this comment.
We have an outstanding todo item for this gray. It will mean expanding the existing scale a bit, so needs a dedicated PR.
I'm not sure variables really necessary for shadows.
| padding-right: 0; | ||
| &.is-selected { | ||
| .dataviews-view-list__item-actions { | ||
| background-color: rgb(247 248 255); |
There was a problem hiding this comment.
This is a 'solid' version of rgba(var(--wp-admin-theme-color--rgb), 0.04), which should probably be a variable too given it's increasing use. I'd lean towards tackling this together, separately.
|
I'm going to merge this since it fixes some troublesome bugs. We can circle back to explore the variables separately. |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #63043.
What?
This PR addresses three issues in the List layout appearance / behavior.
Issue 1
When all fields are toggled off, the alignment is broken:
Issue 2
Awkward reflow occurs when hovering/selecting a row that contains a field with a very long value, or just many fields:
jump.mp4
Issue 3
Clicking around the action buttons will not select the row, despite the hover style suggesting it would:
click.mp4
How?
Here's the result:
update.mp4
Testing Instructions