-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post terms block: add an example #63369
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
I realize the lack of content in my screenshot is because I'm testing in the site editor, where it just shows its placeholder state. But if it's possible to still show content here, it would be useful. |
I think that's a problem in general with these types of blocks, the placeholders are not helpful where we need them most to be: the site editor, which is where they are generally used. When we insert the terms block in a template they look exactly like that, they just say "categories" or "tags". We only see them in context in the frontend. It's a bigger problem than the preview, it's a problem with the block, I would say. |
@jasmussen this is the 'abecedarium' issue. IE show meaningful block previews when there's no context, while still making it obvious what the block does. |
Yep, and not a blocker! |
What?
Add a basic example to the
core/post-terms
block.Part of #30029
Why?
Because it was showing empty before
How?
I define a viewport size for the example
Testing Instructions
Open the block inserter and search for the post tags block, hover over it and you'll see the example. The Post categories block should show the same.
On Global Styles, go to blocks, and search for post terms: it should have a preview.
Testing Instructions for Keyboard
Screenshots or screencast