Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post terms block: add an example #63369

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

MaggieCabrera
Copy link
Contributor

What?

Add a basic example to the core/post-terms block.

Part of #30029

Why?

Because it was showing empty before

How?

I define a viewport size for the example

Testing Instructions

Open the block inserter and search for the post tags block, hover over it and you'll see the example. The Post categories block should show the same.
On Global Styles, go to blocks, and search for post terms: it should have a preview.

Testing Instructions for Keyboard

Screenshots or screencast

Screenshot 2024-07-10 at 18 10 40 Screenshot 2024-07-10 at 18 10 48

@jasmussen
Copy link
Contributor

Good step forward. For some reason I see this:
Screenshot 2024-07-11 at 09 38 30

Can we supply some specific tags and categories as part of the example? That might also let us avoid the typographic widow here:

Screenshot 2024-07-11 at 09 39 26

Copy link

github-actions bot commented Jul 11, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: MaggieCabrera <onemaggie@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@jasmussen
Copy link
Contributor

I realize the lack of content in my screenshot is because I'm testing in the site editor, where it just shows its placeholder state. But if it's possible to still show content here, it would be useful.

@MaggieCabrera
Copy link
Contributor Author

I realize the lack of content in my screenshot is because I'm testing in the site editor, where it just shows its placeholder state. But if it's possible to still show content here, it would be useful.

I think that's a problem in general with these types of blocks, the placeholders are not helpful where we need them most to be: the site editor, which is where they are generally used. When we insert the terms block in a template they look exactly like that, they just say "categories" or "tags". We only see them in context in the frontend. It's a bigger problem than the preview, it's a problem with the block, I would say.

@jameskoster
Copy link
Contributor

@jasmussen this is the 'abecedarium' issue. IE show meaningful block previews when there's no context, while still making it obvious what the block does.

@jasmussen
Copy link
Contributor

Yep, and not a blocker!

@MaggieCabrera MaggieCabrera merged commit e5030c6 into trunk Jul 11, 2024
70 checks passed
@MaggieCabrera MaggieCabrera deleted the add-post-terms-example branch July 11, 2024 15:36
@github-actions github-actions bot added this to the Gutenberg 18.9 milestone Jul 11, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Terms Affects the Post Terms Block [Type] Enhancement A suggestion for improvement.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants