Query Loop Block: remove Posts List variation #63404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -98 B (-0.01%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7feeb43. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9887292839
|
|
As per my comment here, we shouldn't remove this if we don't have an alternative for this one, like dynamic registration of variations for post types. |
priethor
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Works as expected ✅
Without this PR, the Latest posts block variation can be added and it ignores the Inherit query from template setting entirely, causing confusion.
With this PR, the Latest posts block variation doesn't appear on the inserter, and no content is lost if there are instances already on your site.
I personally don't think that is a blocker; there is no harm in the form of content loss by disabling the variation until we have an alternative that works as expected for users. I gave an approval but I don't feel strongly if we don't want to remove it in the end. |
|
There's some discussion here as well: #63353. The alternative could be to rename the block, but it's tricky to say in a few words what not inheriting means. Even "latest" or "recent" posts could be confusing: people might think that's the blog. This block variation is also not very useful for showing recent posts in the sidebar, because it has pagination etc. It's not designed for that. So I don't get the purpose of this variation at all. |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: priethor <priethor@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
This was referenced Sep 3, 2024
fabiankaegy
added
the
Needs Dev Note
97 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
As mentioned here, this is causing more harm than good because when you insert this block, the query won't inherit the main query by default.
This block variation is also not very useful for showing recent posts in the sidebar, because it has pagination etc. It's not designed for that. So it seems this variation does not have any good use cases, or it has bad defaults.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast