Post Actions: Use entity details for capability checks #63423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
Jul 11, 2024
Comment on lines
-637
to
-641
| const { getPostType, canUser } = select( coreStore ); | ||
| const resource = getPostType( postType )?.rest_base || ''; | ||
| return { | ||
| userCanCreatePost: canUser( 'create', resource ), | ||
| }; |
There was a problem hiding this comment.
Prev code triggered a request to the wp/v2 namespace.
Screenshot
There was a problem hiding this comment.
Yes, but it shouldn't affect users. It just makes an extra request.
First, it will call canUser( 'create', '' ), and then when the post type object is resolved, it will call it correctly.
There was a problem hiding this comment.
Duplicate action is also not included in the core, it is in the plugin only for now, so it should not have an impact on 6.6.
|
Size Change: -24 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
jorgefilipecosta
approved these changes
Jul 11, 2024
|
Thank you, @jorgefilipecosta! |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org>
youknowriad
reviewed
Jul 23, 2024
| registry | ||
| .select( coreStore ) | ||
| .canUser( capability, resource, item.id ) | ||
| registry.select( coreStore ).canUser( capability, { |
There was a problem hiding this comment.
There's something I don't understand here. how does this value change when it gets resolved. There's nothing triggering a re-render when the value of this selector changes and isEligible is not an event callback it's something that is called when rendering.
I'm sure we have a hack elsewhere that "hides" the bug, but this is not great.
There was a problem hiding this comment.
The original PR (#62589) might have more details, but I agree that this feels super "hacky."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #63322.
PR updates user capability checks for post actions to use the updated
canUserselector.Note: I decided to do this separately from #63415 since
canUserchecks are somewhat convoluted here.Why?
The code should always use the new method when working with entity and user capabilities.
Testing Instructions
Confirm that post actions work as before in post and site editors.
Testing Instructions for Keyboard
Same.
Screenshots or screencast