Core Data: Mark 'canUser' related actions resolvers as resolved #63435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -9 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Jul 11, 2024
|
|
||
| // Mark related action resolutions as finished. | ||
| if ( action !== requestedAction ) { | ||
| dispatch.finishResolution( 'canUser', [ |
There was a problem hiding this comment.
If two useSelect calls try to retrieve two different actions before the resolution, we'll still be triggering two API requests.
A better approach might be to separate this resolver into a sub selector/resolver no?
There was a problem hiding this comment.
So you're saying, in some scenarios, this could invalidate the existing check at the top?
gutenberg/packages/core-data/src/resolvers.js
Lines 397 to 410 in da558e2
A better approach might be to separate this resolver into a sub selector/resolver no?
Do you have an example?
There was a problem hiding this comment.
No, actually I missed that check and you're right, we seem covered already.
That said, I think we can avoid all of that (both marking as resolved and the check to avoid starting the resolution) by relying on a shared sub resolver/selector.
There was a problem hiding this comment.
That said, I think we can avoid all of that (both marking as resolved and the check to avoid starting the resolution) by relying on a shared sub resolver/selector.
Making a note and happy to follow up on this as "polish step". While I think I have an idea of what you mean by shared sub-resolver/selector. Do you mind sharing an example so we're on the same page 😅
There was a problem hiding this comment.
Something like:
export const canUser =
( requestedAction, resource, id ) => async ( { resolveSelect } ) => {
await resolveSelect.getResourcePermissions( resource, id );
}
youknowriad
approved these changes
Jul 11, 2024
|
Thanks, @youknowriad! |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
…Press#63435) Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
See #63430 (comment).
PR updates the
canUserresolver to mark related actions as resolved when their store records are populated.Testing Instructions
wp.data.select( 'core' ).canUser( 'update', { kind: 'root', name: 'media', id: 1342 } );.wp.data.select( 'core' ).hasFinishedResolution( 'canUser', [ 'read', { kind: 'root', name: 'media', id: 1342 } ] );Testing Instructions for Keyboard
Same.