DataViews: Combine featured image and title in the posts table #63449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
jameskoster,
ellatrix,
jorgefilipecosta and
ntsekouras
youknowriad
added
the
[Feature] DataViews
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +49 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
I'm hesitant here because most of the time, the featured image is empty so we'll have a gray square. Let's see what designers say. |
Hm... yeah. Actually for posts makes more sense than pages.. |
|
It's also visible on the List layout, so I don't think it's a huge problem. But this is a good example of why ideally fields should remain toggle-able in Table layout even when combined. There's a small styling issue with the image container. It's not hugging the image correctly which is messing up the spacing slightly: 
|
Agreed, although it's hard to implement :P |
ellatrix
reviewed
Jul 12, 2024
| { | ||
| id: 'post', | ||
| header: __( 'Title' ), | ||
| children: [ 'featured-image', 'title' ], |
There was a problem hiding this comment.
I wonder if Front Page and Posts Page could now also be a field. Not sure if that needs to be filterable though.
There was a problem hiding this comment.
The features associated with making these fields don't seem particularly useful to me. Columns in particular would add weight to the table, especially as all records except one will be false.
I appreciate it would make these pages a bit easier to locate, but not in a very ergonomic way. Add filter > is posts page > true isn't the quickest flow. Some alternatives we might consider could be:
- Add a dedicated view for pages associated with settings. It would include the front page, posts page, privacy policy page (if set), products page, cart, checkout (if Woo is installed), etc.
- Include the badge in when searching. IE if I search the All pages view for 'Front page', 'homepage', etc. then the static homepage should be listed even if the title doesn't contain those words.
Edit: I suppose they could be coded as fields, but 'hidden' in the UI except for the badge that exists today. Apologies if that was the implied idea and I went off on a tangent :)
|
@youknowriad do you think we should proceed with this one? |
|
I feel before proceeding here, we should first address the ability to hide/show these combined fields in the "properties" section of the view config first no? Especially given that the featured image is almost always empty for pages.. |
|
Perhaps something like this could work: 
When combined the Featured Image item is locked in position, and the re-order tools are not available. The combine/detach actions can come later. |
|
cc @oandregal as I believe he's working on a PR that alleviate some of my concerns: ability to hide the combined fields. |
Yeah, I started looking around this area and commented on something related at 64999 It doesn't address the particular feature you mentioned (hide the individual fields that are part of a combination), but I'm happy to look into that after it lands. |
|
Not directly related to combined fields but I feel we need to fix this before: stress-testing primaryFields, mediaFields, and view.fields. Let me know your thoughts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58012
What?
This PR combines the "title" with the "featured image" fields in the "pages" dataviews.
Testing Instructions
1- Open the pages dataviews page
2- Check that the featured image is combined with the "title" field in the table layout