FlatTermSelector: Be more defensive about termIds #63461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible (likely through a bug elsehwere) for FlatTermSelector to completely crash the editor if it can't get termIds from the post being edited. This change prevents that crash. The error can happen when <FlatTermSelector> tries to access _termIds.join and _termIds.length even when _termIds is undefined. This is undefined if the current editor state doesn't have any changed for the relevent attribute [0] and the original post doesn't have the relevent attribute [1]. [0] https://github.com/WordPress/gutenberg/blob/4da057ecd6958d40b8f2a83db1152320e5f161e6/packages/editor/src/store/selectors.js#L329 [1] https://github.com/WordPress/gutenberg/blob/4da057ecd6958d40b8f2a83db1152320e5f161e6/packages/editor/src/store/selectors.js#L276
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +1 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
Mamaduka
added
[Feature] Document Settings
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
Co-authored-by: dsas <dsas@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Be more defensive against bad data in
<FlatTermSelector>that could cause a crash.Why?
It's possible (likely through a bug elsewhere) for
<FlatTermSelector>to completely crash the editor if it can't gettermIdsfrom the post being edited. This change prevents that crash.The error can happen when
<FlatTermSelector>tries to access_termIds.joinand_termIds.lengtheven when_termIdsis undefined. This is undefined if the current editor state doesn't have any changes for the relevant attribute and the original post doesn't have the relevant attribute. This shouldn't be possible normally.How?
Use the optional chaining operator.
Testing Instructions
It's difficult to construct an artificial test case, but on the happy path then nothing should change at all, using the post tags in the sidebar when editing a post should continue to work exactly as it does now.