Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: updated soundcloud icon for social link block #63504

Merged

Conversation

troychaplin
Copy link
Contributor

What?

Updating the soundcloud social link icon as request in #59084

Why?

Because SoundCloud has a new company logo

How?

Generated new SVG

Testing Instructions

  • Checkout branch
  • Load local WP
  • Add social link block
  • Add soundcloud
  • View icon (very subtle change in icon)

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: troychaplin <areziaal@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jul 12, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @troychaplin! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@ryanwelcher ryanwelcher added [Package] Blocks /packages/blocks [Type] Feature New feature to highlight in changelogs. labels Jul 12, 2024
Copy link
Contributor

@ryanwelcher ryanwelcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me. Seems pretty straightforward. I was working with @troychaplin at WordCamp Canada on this.

@ryanwelcher ryanwelcher merged commit 0aecc89 into WordPress:trunk Jul 12, 2024
67 of 68 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.9 milestone Jul 12, 2024
scruffian pushed a commit that referenced this pull request Jul 15, 2024
Co-authored-by: troychaplin <areziaal@git.wordpress.org>
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jul 18, 2024
Co-authored-by: troychaplin <areziaal@git.wordpress.org>
@troychaplin troychaplin deleted the feature/GH-59084-soundcloud-icon branch July 20, 2024 02:53
@priethor priethor added [Block] Social Affects the Social Block - used to display Social Media accounts [Type] Enhancement A suggestion for improvement. and removed [Type] Feature New feature to highlight in changelogs. labels Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Blocks /packages/blocks [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants