Issue template: use checkboxes instead of dropdown #63523
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ellatrix
added
the
[Type] Project Management
There was a problem hiding this comment.
I also suggested this problem in #51815.
To actually test the issue template, I created a test repository in my GitHub account.
The code from this PR is reflected here:
https://github.com/t-hamano/issue-template-test/issues/new?assignees=&labels=%5BType%5D+Bug&projects=&template=Bug_report.yml
| options: | ||
| - 'Yes' | ||
| - 'No' | ||
| - label: 'Yes' | ||
| validations: |
There was a problem hiding this comment.
It seems that if we want a checkbox to be required, we need to define it in the options field, not the validations field.
See this code sample: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-issue-forms
There was a problem hiding this comment.
Ok, it should be good now. You can actually preview it here https://github.com/WordPress/gutenberg/blob/dc41b4fd10d6828f3985cffecfc52143d1011646/.github/ISSUE_TEMPLATE/Bug_report.yml
There was a problem hiding this comment.
LGTM! Just to be sure, I tested it in my repository and the validation for the checkboxes seems to work.
cea71fd54c538e2d06d879b56837bee6.mp4
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: alexstine <alexstine@git.wordpress.org>
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: alexstine <alexstine@git.wordpress.org>
What?
Also removes "multiple", it doesn't make sense at all to select both. I've also just left a checkbox for Yes.
Why?
It's super annoying to have to open a dropdown twice to be able to file a bug report.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast