Background Image: Make panel appear in a consistent location #63551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@WordPress/gutenberg-design can you please confirm the preferred location for the background image panel is beneath the color panel? Which on trunk is the case for the Styles tab in the inspector. |
This was referenced Jul 15, 2024
|
Size Change: +1 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Probably related #63188. |
|
There's still the larger open question around whether "Background image" is a bespoke panel going forward, or not. If yes, I'd tend to think that it should be "Background", and include the background color, which can also include a gradient that is affected by the same background position tools that the image is. But that's separate, and this PR does fix the order to be better. |
|
Consistently placing this panel after the Color panel makes sense to me too. It will also make the settings easier to find if/when all background controls converge in a single panel down the road. |
andrewserong
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Nice polishing here! Particularly now that the background image controls are in a popover, it feels really good to me having them close to the Color controls:
✅ Individual Verse block looks good
✅ Individual Group block looks good
✅ Selecting multiple Verse blocks looks good, allows selecting background image
✅ Selecting multiple Group blocks looks good, allows selecting background image
LGTM! 🚀
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
…ss#63551) Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
|
Thanks for following up on this! 🚀 |
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #63188
Issue was also flagged in #61382 (review)
What?
This PR makes sure that the background image panel appears in the same location between blocks regardless of whether the block utilises the styles tab or has all panels within the block inspector itself.
The background image panel was also added to those displayed for multi-block selections when there are multiple blocks of the same type selected with support for background images.
Why?
How?
Testing Instructions
Screenshots or screencast
Verse Block
Before and After
| Before | After | |---|---| |Group Block ( No change )
Before and After
Multiple Selections
Before and After