Disallow scrolling the block preview. #63558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.75 MB ℹ️ View Unchanged
|
|
The main issue with this I see with the Image block and the columns block:
The columns block preview doesn't look amazing in either case in my opinion anyway |
|
Flaky tests detected in ce522bb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9938829628
|
We need to add a viewport width so that columns actually display side by side. |
|
Good catch on the cropped pieces, however that preview was never meant to be scrollable, just like it isn't in the flyout preview either. It's a small glimpse at the content, but height-limited to not push down important inspector content substantially. Mont Blanc has served us well, but it could be time to find something better. Perhaps we can find something more landscape shaped, so the caption is visible. To that end, I see this more as a forcing function to improve our previews: the content, etc., than anything else. It's also an issue when you change the styling:
That said, and as is visible in this GIF too, I just discovered another issue 🙈—if you scale up the text in a paragraph, then scale it back down, the text stays pushed downwards. I'm about to head AFK for a couple of weeks. Outside of an approval of this one so we can land it, others should feel free to push to this branch (i.e. if a quick viewport width improves the image, seems fine). Otherwise I'll pick it back up when I return. |
MaggieCabrera
approved these changes
Jul 16, 2024
|
I'm going to have a look at the problem with the text being pushed cause I think I know why it is, I'll add to this PR |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
priethor
added
the
Global Styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The block preview is scrollable (related, #45719):
This PR makes it not scrollable:
Why?
The content is inert, not meant to be interacted with.
Testing Instructions
Go to site editor > global styles. Go to blocks, select a block such as paragraph. The preview here should not be scrollable.