Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FontSizePicker: Fix docs for default units #63577

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

mirka
Copy link
Member

@mirka mirka commented Jul 15, 2024

Fixup for #60607

What?

Updates the docs for FontSizePicker to reflect the changes introduced in #60607.

Testing Instructions

Readme, JSDocs, and Storybook should show the correct default.

@mirka mirka added [Type] Developer Documentation Documentation for developers [Package] Components /packages/components labels Jul 15, 2024
@mirka mirka self-assigned this Jul 15, 2024
@mirka mirka requested a review from ajitbohra as a code owner July 15, 2024 15:43
Copy link

github-actions bot commented Jul 15, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mirka mirka requested a review from a team July 15, 2024 17:02
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@mirka mirka merged commit 0b8e0b5 into trunk Jul 15, 2024
67 of 68 checks passed
@mirka mirka deleted the fix/font-size-picker-unit-docs branch July 15, 2024 18:34
@github-actions github-actions bot added this to the Gutenberg 18.9 milestone Jul 15, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jul 18, 2024
Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants