Separator, Code: don't require Enter for shortcut #63654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @jarekmorawski. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +168 B (+0.01%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
It's testing well for me in both editors. Nice work! 🙌 Site editorsite-editor.movPost editorpost-editor.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Introduces a new transform/shortcut type
input, which transform text into a block as soon as the sequence is complete (instead of waiting forEnter).Question: in case of the separator, would it make more sense to also add an empty paragraph after it?
Why?
Because currently the
entershortcut is not discoverable enough, and there's not really any harm in transforming sooner. It's still possible to undo the transform.How?
Testing Instructions
Testing Instructions for Keyboard
Type
---or```in a paragraph block, which should transform it to a Separator or Code block respectively.Screenshots or screencast