-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patterns: Render draggable only when enabled #63715
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +7 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense. The BlockDraggable
component does a similar early return.
gutenberg/packages/block-editor/src/components/block-draggable/index.js
Lines 175 to 177 in 0a7e10d
if ( ! isDraggable ) { | |
return children( { draggable: false } ); | |
} |
Thanks, @Mamaduka! |
What?
Render the
Draggable
components inside the inserter patterns only when draggable is actually enabled.Why?
Currently, we'll render a
<Draggable />
with its draggable chip unnecessarily when draggable is disabled. This feels unnecessary since, in some instances, the patterns will intentionally never be draggable.How?
We're skipping the render of
Draggable
and the draggable chip. This results in a smaller component tree and fewer items in the DOM tree when patterns are not draggable.Testing Instructions
Testing Instructions for Keyboard
None
Screenshots or screencast