-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide source filter in my patterns #63831
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: -4 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this cleans up the code quite a bit too which is a bonus
packages/block-editor/src/components/inserter/block-patterns-tab/patterns-filter.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patterns in this category will always be source = user, so this change makes sense to me.
b73dd69
to
a905733
Compare
What?
Resolve part of #61826. Hide the source filter if the category is "My patterns".
Why?
See #61826 (comment). The source filter will only have "User" available if the category is "My patterns".
How?
Hide the source filter if the category is "My patterns".
Testing Instructions
Screenshots or screencast
Before
After