Tag Cloud: Prevent duplicate spacing in editor #63832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +161 B (+0.01%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Jul 23, 2024
|
Thanks for the thorough review @ramonjd
For block supports themselves, the Tag Cloud block should already omit those block support attributes and classes. Anything can be styled via theme.json and global styles, so I agree this isn't a complete solution. In my view, the only complete solution is to refactor the block to use the REST API instead of server-side rendering. If we go the route of resetting all styles, we'd need to do that for anything that could be styled via theme.json. That includes any custom CSS the theme or user adds. I'm not sure that is feasible in the short term either. For now, this PR addresses the most glaring issue, buying time to see the impact of what remains and/or refactor the block. |
aaronrobertshaw
deleted the
fix/remove-duplicate-spacing-for-tag-cloud-in-editor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #63716
What?
Avoids the duplicate application of default padding and margin styles on the Tag Cloud block in the editor due to its use of server-side rendering.
Why?
Without these changes, default margin and padding are applied twice creating a visual difference between the editor and frontend.
How?
.wp-block-tag-cloudclassAlternate Approach
Initially, it was suggested to reset the spacing styles on the outer wrapping element in the editor. The catch here is that there is default padding for different alignments and the CSS classes for those alignments are only applied to the outer wrapper.
If the spacing style resets occur on the outer wrapper, these defaults need to be plumbed through to the inner
p.wp-block-tag-cloudelement. The current approach in this PR minimises any additional CSS to reset spacing.Testing Instructions
p.wp-block-tag-cloudelement and ensure that padding and margin styles are resetScreenshots or screencast