-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Column: Enable border radius support #63924
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @gabrieltogan, @porg, @bradhogan. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have followed the testing instructions and the radius is working as described. Thank you for the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple, performs just like the group block. Not overthinking it. Nice.
Thanks for the reviews and getting this one merged, appreciate it 🚀 |
@gabrieltogan mind sharing your WordPress.org username so I can ensure its included in the 6.7 credits listing? |
Fixes: #41345
What?
Enables border-radius support for individual Column blocks.
Note: This PR does not add any automatic clipping of overflow content as discussed on the original issue. This will bring the Column block in line with the Group block.
Why?
To unlock more design possibilities and reduce the need for unnecessary wrapping of content in Group blocks to achieve the same end.
How?
Enable border-radius block support.
Testing Instructions
Screenshots or screencast