Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column: Enable border radius support #63924

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

aaronrobertshaw
Copy link
Contributor

Fixes: #41345

What?

Enables border-radius support for individual Column blocks.

Note: This PR does not add any automatic clipping of overflow content as discussed on the original issue. This will bring the Column block in line with the Group block.

Why?

To unlock more design possibilities and reduce the need for unnecessary wrapping of content in Group blocks to achieve the same end.

How?

Enable border-radius block support.

Testing Instructions

  1. Open the site editor and navigate to Styles > Blocks > Column
  2. Add a global border radius for Column blocks
  3. Add some columns with background color to the page or post and ensure radius is displayed correctly
  4. Save and confirm the radius is applied correctly on the frontend
  5. Back in the editor select a Column block instance
  6. Tweak that instance's border radii and confirm those values override the global styles
  7. Save and confirm display on the frontend.

Screenshots or screencast

Screenshot 2024-07-25 at 6 26 40 PM

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Block] Columns Affects the Columns Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Jul 25, 2024
@aaronrobertshaw aaronrobertshaw self-assigned this Jul 25, 2024
Copy link

github-actions bot commented Jul 25, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @gabrieltogan, @porg, @bradhogan.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: gabrieltogan, porg, bradhogan.

Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>
Co-authored-by: richtabor <richtabor@git.wordpress.org>
Co-authored-by: mikemcalister <mmcalister@git.wordpress.org>
Co-authored-by: maurodf0 <maurodf@git.wordpress.org>
Co-authored-by: bgardner <bgardner@git.wordpress.org>
Co-authored-by: deryckoe <deryck@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@carolinan carolinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have followed the testing instructions and the radius is working as described. Thank you for the PR.

Copy link
Member

@richtabor richtabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple, performs just like the group block. Not overthinking it. Nice.

@richtabor richtabor merged commit 285a304 into trunk Jul 26, 2024
71 checks passed
@richtabor richtabor deleted the add/column-border-radius-support branch July 26, 2024 20:29
@github-actions github-actions bot added this to the Gutenberg 19.0 milestone Jul 26, 2024
@aaronrobertshaw
Copy link
Contributor Author

Thanks for the reviews and getting this one merged, appreciate it 🚀

@jeffpaul
Copy link
Member

jeffpaul commented Nov 8, 2024

@gabrieltogan mind sharing your WordPress.org username so I can ensure its included in the 6.7 credits listing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Columns Block > allow border radius on columns
4 participants