Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Title: Add border block support #64024

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

akasunil
Copy link
Member

What?

Add border block support to the Post Title block.

Part of #43247

Why?

Post Title block is missing border support.

How?

Adds the border block support in block.json

Testing Instructions

  • Go to Global Styles setting ( under appearance > editor > styles > edit styles > blocks )
  • Make sure that Post Title block's border is configurable via Global Styles
  • Verify that Global Styles are applied correctly in the editor and frontend
  • Edit template/page, Add Post Title block and Apply the border styles
  • Verify that block styles take precedence over global styles
  • Verify that block borders display correctly in both the editor and frontend

Please refer to the attached video for more information.

Screenshots or screencast

Blog-Home-.-Template-.-gutenberg-.-Editor-.-WordPress.14.webm

@akasunil akasunil added [Type] Enhancement A suggestion for improvement. [Block] Post Title Affects the Post Title Block labels Jul 27, 2024
@akasunil akasunil requested a review from ajitbohra as a code owner July 27, 2024 17:15
Copy link

github-actions bot commented Jul 27, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: akasunil <sunil25393@git.wordpress.org>
Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@aaronrobertshaw aaronrobertshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the thorough PR description and test instructions 👍

✅ Global styles display correctly
✅ Block instance styles override global styles
✅ Styling is consistent between editor and frontend
✅ Box-sizing was already set to border-box for when parent enforces an explicit width

LGTM 🚢

@akasunil akasunil merged commit 05bf9bb into trunk Jul 29, 2024
67 checks passed
@akasunil akasunil deleted the add/post-title-border-support branch July 29, 2024 09:11
@github-actions github-actions bot added this to the Gutenberg 19.0 milestone Jul 29, 2024
@fabiankaegy fabiankaegy mentioned this pull request Oct 1, 2024
97 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Title Affects the Post Title Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants