Font Library Modal: Remove notice context and add message when fonts updated #64030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -31 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
mikachan
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Thanks @t-hamano, this is looking good to me!
- I saw notices when installing, uploading, and removing fonts ✅
- I saw notices when updating font variations ✅
- All notices disappear on page/tab change ✅
I've just started a re-run of the failed test as the failure didn't seem to be anything to do with these changes.
|
@mikachan Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54601
Part of #58428
What?
This PR achieves the following two things:
Why?
The current notification status is shared across the entire Font Library modal. Therefore, we need to reset the notification status when we open the Font Library or switch tabs.
The notification status is specific to each tab and does not need to be managed centrally as a context.
How?
Store the notification status as a state for each tab. This ensures that the notification is reset when you open the Font Library modal or switch tabs.
Testing Instructions
Screenshots or screencast
f7ab5866ed3919adecd21e3e2aae8c5d.mp4