Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Background images: add support for theme.json ref value resolution #64128

Merged
merged 11 commits into from
Aug 15, 2024
Merged

Background images: add support for theme.json ref value resolution #64128

merged 11 commits into from
Aug 15, 2024

Commits on Aug 15, 2024

  1. - resolve refs before passing styles to style engine in wp_theme_json 

    - add tests

- adds tests

Check for string types in background image so it will apply defaults for blocks.
Update comments
    @ramonjd
    ramonjd committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    7f7ea9a View commit details
    Browse the repository at this point in the history

  2. - consolidate all resolutions in the background panel (image and ref) 

    - remove useGlobalStyleLinks completely
- delete theme URI utils

Remove string condition

LInto
    @ramonjd
    ramonjd committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    e359a75 View commit details
    Browse the repository at this point in the history

  3. Reconcile global styles default value assignment an ref resolution af… 

    …ter rebase.
    @ramonjd
    ramonjd committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    550098a View commit details
    Browse the repository at this point in the history

  4. Update tests and perform check for background size before use.

    @ramonjd
    ramonjd committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    bc8dcc3 View commit details
    Browse the repository at this point in the history

  5. Fixes a but where a ref value will be resolved even where a url value… 

    … exists. This will occur when base and user configs are merged.

Update tests and perform check for background size before use.

Update tests and perform check for background size before use.
    @ramonjd
    ramonjd committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    fb65340 View commit details
    Browse the repository at this point in the history

  6. The commit tries to ensure that backgroundImage style objects are not… 

    … merged, but replaced when merged theme.json configs. So, for example, an incoming config such as a saved user config should overwrite the background styles of the base theme.json, where it exists.
    @ramonjd
    ramonjd committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    cb34d72 View commit details
    Browse the repository at this point in the history

  7. Fix bug where the style node list was being filtered, add comment.

    @ramonjd
    ramonjd committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    87bb56b View commit details
    Browse the repository at this point in the history

  8. Fix unit test for merging background image styles

    @aaronrobertshaw @ramonjd
    aaronrobertshaw authored and ramonjd committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    aa7be71 View commit details
    Browse the repository at this point in the history

  9. Tweak wording for readability

    @aaronrobertshaw @ramonjd
    aaronrobertshaw authored and ramonjd committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    70ee622 View commit details
    Browse the repository at this point in the history

  10. Tweak comment

    @aaronrobertshaw @ramonjd
    aaronrobertshaw authored and ramonjd committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    2099c31 View commit details
    Browse the repository at this point in the history

  11. Reduce the scope of the merge PHP unit test - let's just test backgro… 

    …und styles as general styles are tested above in test_merge_incoming_data
    @ramonjd
    ramonjd committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    f21a3e9 View commit details
    Browse the repository at this point in the history