-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template Part: Fix 'can user edit' check #64137
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +13 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Makes sense and tests as advertised 👍 🚀
Thanks for testing, @tyxla! |
What?
PR contains the following fixes and improvements for the Template Part block:
canUser
selector after resolving the template part entity. This prevents making additionalOPTIONS
requests (see Core Data: Resolve user capabilities when fetching an entity #63430). The block controls are only rendered after the entity finishes resolution.Testing Instructions
OPTIONS
request is made for template parts. You can usetemplate-parts
as a filter.Testing Instructions for Keyboard
Same.
Screenshots or screencast