Quote Block: Add align support #64188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Block] Quote
t-hamano
requested review from
tellthemachines,
andrewserong and
aaronrobertshaw
t-hamano
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Mobile unit tests are failing, so I'm trying to investigate why 👀 |
t-hamano
force-pushed
the
quote/align-support
branch
from
dbc29a2 to
52452f7
Compare
|
Size Change: +9 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
@geriux @dcalhoun I'm trying to add wide support to quote blocks, and I've made two changes to fix the mobile unit test failures. I'd be grateful if you could confirm that these changes are OK 🙇♂️
You can see these error messages in the following log: https://github.com/WordPress/gutenberg/actions/runs/10212071395/job/28255325475 |
I'll take a look now |
|
I've just tested these changes and they are working as expected, the new align options are working for the mobile editor as well. The code changes look good to me, thanks for the ping! 🚀 |
ramonjd
reviewed
Aug 14, 2024
There was a problem hiding this comment.
Looking pretty good!
✅ Align left/right applies to the block and appears in the document flow as I'd expect
✅ The alignment of Pullquote blocks persists between transforms
Here's me messing around with block conversions:
2024-08-14.14.37.40.mp4
I haven't tested in native yet - my computer is complaining about dependencies...
|
I don't see any errors in IOS, though it's hard to test on the small screen. But it looks like controls appear okay. 2024-08-14.15.21.22.mp4Also on iPad testing the pullquote > quote transform 2024-08-14.15.33.15.mp4 |
ramonjd
approved these changes
Aug 14, 2024
|
Thank you for your reviews! As a follow-up to this PR, I plan to add layout support to this block. After that follow-up is complete, I will reconsider deprecating the Pullquote block in #11610. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #43248
Related to #11610
What?
This PR adds the
alignsupport to the Quote block.Why?
In #11610, it is suggested that the Pullquote block may be deprecated. If the Pullquote block is deprecated, the Quote block must support as many of the same features as possible. The most important feature that the Quote block is missing is
alignsupport.How?
Simply added algin support.
Currently, this block does not support layout, so the content width will be the full width of the block. As a follow-up, I'm considering adding layout support to this block as well, as in #45326.
Testing Instructions
Screenshots or screencast