Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components: Cleanup flaky unit test sleep() hacks #64205

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Components: Cleanup flaky unit test sleep() hacks #64205

merged 1 commit into from
Aug 2, 2024

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Aug 2, 2024

What?

Cleans up the hacks we introduced to deal with flaky tests.

Fixes #59071.

Why?

#59071 adds context as to why those were introduced.

With the latest version of Ariakit since #64066, those shouldn't be necessary anymore

How?

We're removing the arbitrary sleep() calls.

Testing Instructions

Verify all tests pass.

Testing Instructions for Keyboard

None

Screenshots or screencast

None.

@tyxla tyxla added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Package] Components /packages/components labels Aug 2, 2024
@tyxla tyxla requested a review from a team August 2, 2024 13:43
@tyxla tyxla self-assigned this Aug 2, 2024
@tyxla tyxla requested a review from ajitbohra as a code owner August 2, 2024 13:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: DaniGuardiola <daniguardiola@git.wordpress.org>
Co-authored-by: diegohaz <hazdiego@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

This was referenced Aug 2, 2024
Merged
Closed
DaniGuardiola
DaniGuardiola approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@DaniGuardiola DaniGuardiola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@tyxla tyxla merged commit f9216d7 into trunk Aug 2, 2024
68 checks passed
@tyxla tyxla deleted the cleanup/unit-test-sleep-hacks branch August 2, 2024 14:34
@github-actions github-actions bot added this to the Gutenberg 19.0 milestone Aug 2, 2024
@snyk-io snyk-io bot mentioned this pull request Aug 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniGuardiola DaniGuardiola DaniGuardiola approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@tyxla tyxla

Labels
[Package] Components /packages/components [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Milestone
Gutenberg 19.0
Development

Successfully merging this pull request may close these issues.

Components: Revert flaky unit test sleep() hacks
2 participants
@tyxla @DaniGuardiola