Navigation: Hide loading when overlay menu is selected #64262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +17 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
getdave
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Hides navigation loading spinner when the option to always display the overlay menu is selected.
Why?
To decrease the amount of jumping caused by the navigation block during the loading process. This is especially valuable for rendering pattern previews when the navigation block is used in a pattern.
Found while working on #44750.
How?
Right now, if the user has a navigation block with the "always" option set, they'll see a spinner and then a navigation menu. However, we can display the menu icon immediately, and the loading will still happen in the background. This is what this PR suggests. Then, if the user is quick enough to click on the navigation icon in the navigation menu popover, they'll see the loading bar - then, and only then. This doesn't affect the behavior if any of the other "Overlay Menu" options are chosen.
One other issue I've noticed, and this is pre-existing:
The custom popover implementation that's used to display a preview of the navigation menu will stay behind the block toolbar. I don't think that's expected, and it looks awkward on small devices (as shown in the preview below). Should we use an actual dialog component instead and remove the custom implementation altogether? @WordPress/gutenberg-components thoughts?
Testing Instructions
Testing Instructions for Keyboard
None
Screenshots or screencast
Before:
Screen.Recording.2024-08-05.at.17.57.22.mov
After:
Screen.Recording.2024-08-05.at.17.56.01.mov