Stop unwanted drag and drop operations within section Patterns in Zoom Out mode #64331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +3.21 kB (+0.18%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
getdave
added
[Feature] Zoom Out
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
getdave
changed the title
MaggieCabrera
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Blocks the ability to drag patterns inside existing top level patterns in Zoom Out mode. Patterns should only be insertable at the top level.
Also disable ability for horizontal insertion at the topmost level.
Closes #63862
Why?
Zoom Out is about composing Pages from Patterns as sections. These "sections" are the building blocks of the page. As a result when constructing a page using drag and drop it is confusing if
Both of these interactions also make the experience prone to error.
What we need is for the top level sections to be selectable (
blockEditingMode === 'default') but to disable the ability to drag and drop inside of them. This is a hybrid state, specific to Zoom Out mode, which means we need to add special conditions.In addition to this, drag and drop interactions can have an "operation" which can be
insertorgroup. Insert is standard "insert block(s) here". Group however, is for special interactions such as allowing for the creation of "Row" layouts by dragging one group to the left/right of another group.In Zoom Out mode we are composing sections and thus such "grouping" operations are undesirable.
How?
Change the order of the conditionals that govern the availability of drop zones, so that when in Zoom Out mode, all dropzones (except those at the section root) are disabled. This means that you cannot drag and drop inside the individual section blocks, but you can drag and drop between them.
Moreover, we hide the insertion points at the topmost level if/when the drag/drop operation type is
group.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before
Screen.Capture.on.2024-08-08.at.10-38-22.mp4
After
Screen.Capture.on.2024-08-08.at.10-28-03.mp4
Co-authored-by: Maggie Cabrera 3593343+MaggieCabrera@users.noreply.github.com
Co-authored-by: scruffian scruffian@git.wordpress.org