Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Revert "Adds experimental blocks flag for blocks that may not be ready for general use (#64121)" #64336

Closed
wants to merge 1 commit into from

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Aug 7, 2024

What?

This PR reverts the experimental flag for blocks added in #64121.

Note

Note: This PR is not guaranteed to be merged, but was prepared in advance to prevent #64121 from shipping in Gutenberg version 19.0.

Why?

#64121 was added for a reason:

Blocks in development may not be ready for general use. By having users opt in to an experiment to test these blocks, we can iterate without worrying about writing multiple block deprecations.
Once a block is stable, it can be promoted from the experiment to being included by default in block-library.

However, the following opinion exists:

A single block is usually well scoped and when it's quite close to land, but we're not sure if it's going to be stable for a WP release, we have the "__experimental" flag in block's metadata (block.json). In all other cases, the block should be tested in the respective PR and not add extra unfinished code in the repo.

We probably shouldn't add such an option until we have a clear rule of ​​how to handle "experimental" blocks in the Gutenberg plugin.

@t-hamano t-hamano added the [Type] Experimental Experimental feature or API. label Aug 7, 2024
@t-hamano t-hamano self-assigned this Aug 7, 2024
@t-hamano
Copy link
Contributor Author

Based on the discussion in 64121, I'm closing this PR.

@t-hamano t-hamano closed this Aug 16, 2024
@t-hamano t-hamano deleted the revert-ff59ffa branch August 16, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Experimental Experimental feature or API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant