DataViews Extensibility: Allow unregistering the duplicate post action #64441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
youknowriad
requested review from
Mamaduka,
oandregal,
jsnajdr,
sirreal,
jorgefilipecosta and
ntsekouras
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
commented
Aug 12, 2024
ntsekouras
reviewed
Aug 12, 2024
Mamaduka
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
I couldn't spot any regression with the actions, and the code looks good. Can't speak about TypeScript parts :P
I noticed that we have three different duplicate actions (one for patterns, one for template and template parts and one for the rest of the post type. This seems largely unnecessary and we could unify probably.
100%. We should probably do it before stabilizing the feature.
|
Size Change: +99 B (+0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
oandregal
reviewed
Aug 13, 2024
| }; | ||
|
|
||
| export const orderField: Field< PostWithPageAttributesSupport > = { | ||
| export const orderField: Field< BasePost > = { |
There was a problem hiding this comment.
What's the relation between these fields + .../types with the usePostFields hook defined in edit-site? Last I tried to consolidate the two in a single place there was a few dependencies in the usePostFields hook to get rid of.
getdave
pushed a commit
that referenced
this pull request
Aug 14, 2024
#64441) Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: sirreal <jonsurrell@git.wordpress.org> Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org>
97 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #61084
Similar to #62647
What?
In #62052 an API to register and unregister dataviews actions has been implemented. But in order to allow third-party developers to be able to unregister these actions, we need to be using the same actions in Core to register the core actions. The current PR explore the possibility to use the API to register one action: "duplicate post part".
Note I noticed that we have three different duplicate actions (one for patterns, one for template and template parts and one for the rest of the post type. This seems largely unnecessary and we could unify probably.
Testing Instructions
1- Open the pages dataviews.
2- You should be able to see the "duplicate" action in the actions dropdown.
3- you can try to use the action.