-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RangeControl
: tweak mark and label absolute positioning
#64487
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
RangeControl
: tweak mark and label absolute positioning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mirka ! |
… to fit the original design.
699bfda
to
d8ae9c6
Compare
What?
Resolves: #64481
This commit tweaks the position of the range control marks and labels to fit the original 2020 design.
Why?
I can't find the regression, but there seems to be one.
How?
Tweaky tweaky.
Testing Instructions
The easiest way to test is to run story book locally —
npm run storybook:dev
— and head to http://localhost:50240/?path=/story/components-rangecontrol--with-integer-step-and-marksCheck that that the marks and labels sit neat behind, and under the range control bar.
Compare with trunk: https://wordpress.github.io/gutenberg/?path=/story/components-rangecontrol--with-integer-step-and-marks
I also added some marks to existing block editor controls to check for side-effects.
Here's the Cover block opacity range control:
2024-08-14.12.34.04.mp4
Diff for the above cover block test
Screenshots or screencast