TextControl: Fix remaining 40px size violations #64594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
|
Size Change: -52 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
mirka
commented
Aug 17, 2024
| @@ -319,6 +319,7 @@ module.exports = { | |||
| 'FontSizePicker', | |||
| 'NumberControl', | |||
| 'RangeControl', | |||
| 'TextControl', | |||
There was a problem hiding this comment.
Moved to the stricter rule that doesn't allow __next40pxDefaultSize={ false }, now that we're done migrating.
| @@ -150,8 +150,7 @@ function NonDefaultControls( { format, onChange } ) { | |||
| /> | |||
| { isCustom && ( | |||
| <TextControl | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
| @@ -227,16 +227,14 @@ const ImageURLInputUI = ( { | |||
| checked={ linkTarget === '_blank' } | |||
| /> | |||
| <TextControl | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
There was a problem hiding this comment.
Image block ▸ "Link" in block toolbar ▸ Down caret ("Link settings") dropdown in the popover.
| Before | After |
|---|---|
 |
 |
| @@ -63,8 +63,7 @@ function InputFieldBlock( { attributes, setAttributes, className } ) { | |||
| ) } | |||
| <InspectorControls group="advanced"> | |||
| <TextControl | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
There was a problem hiding this comment.
Enable "Form and input blocks" in Gutenberg Experimental settings. Insert Form block. Click on one of the input blocks.
| Before | After |
|---|---|
 |
 |
| @@ -380,8 +380,7 @@ function ButtonEdit( props ) { | |||
| <InspectorControls group="advanced"> | |||
| { isLinkTag && ( | |||
| <TextControl | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
| @@ -51,8 +51,7 @@ function RenameItemModalContent( { dataviewId, currentTitle, setIsRenaming } ) { | |||
| > | |||
| <VStack spacing="5"> | |||
| <TextControl | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
There was a problem hiding this comment.
Rename the custom view you just made.
| Before | After |
|---|---|
 |
 |
| @@ -44,7 +44,7 @@ const getFuturePostUrl = ( post ) => { | |||
| function CopyButton( { text, onCopy, children } ) { | |||
| const ref = useCopyToClipboard( text, onCopy ); | |||
| return ( | |||
| <Button variant="secondary" ref={ ref }> | |||
| <Button __next40pxDefaultSize variant="secondary" ref={ ref }> | |||
There was a problem hiding this comment.
The thing that appears after you just publish a post.
| Before | After |
|---|---|
 |
 |
| @@ -24,8 +24,7 @@ function PostSlugControl() { | |||
|
|
|||
| return ( | |||
| <TextControl | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
There was a problem hiding this comment.
This doesn't appear anywhere in the app anymore, but code-wise it looks safe to change.
| @@ -407,8 +407,7 @@ export function HierarchicalTermSelector( { slug } ) { | |||
| <Flex direction="column" gap="4"> | |||
| { showFilter && ( | |||
| <TextControl | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
There was a problem hiding this comment.
The category filter that appears in the post sidebar when there are many categories.
| Before | After |
|---|---|
 |
 |
May want to switch to a SearchControl (#64593).
| @@ -169,8 +169,7 @@ export default function ReusableBlockConvertButton( { | |||
| > | |||
| <VStack spacing="5"> | |||
| <TextControl | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
There was a problem hiding this comment.
Doesn't appear in the app anymore, but should be safe (same as #64213 (comment)).
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
approved these changes
Aug 17, 2024
| @@ -319,6 +319,7 @@ module.exports = { | |||
| 'FontSizePicker', | |||
| 'NumberControl', | |||
| 'RangeControl', | |||
| 'TextControl', | |||
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
* Fix in DateFormatPicker * Fix in ImageURLInputUI * Fix in Button block * Fix in Form block InputFieldBlock * Fix in Form block * Fix in Image block content only mode * Fix in Navigation block * Fix in Post Comment block (deprecated) * Fix in Featured Image block * Fix in Categories block * Fix in Title block * Fix in Social Icons block * Fix in Template Part block * Fix in Video block track editor * Fix in Dataviews Add new view modal * Fix in Dataviews Rename view modal * Fix in PostPublishPanel * Fix in PostSlug component (unused in app) * Fix in HierarchicalTermSelector * Fix in ReusableBlockConvertButton (unused in app) * Move to stricter lint rule * Update snapshot Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #63871
What?
Fixes the remaining 40px size violations for TextControl.
Testing Instructions
See inline comments.