DataViews: load the filter toggle as open if there are primary filters #64651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
oandregal
requested review from
youknowriad,
jameskoster,
jorgefilipecosta and
ntsekouras
oandregal
added
[Type] Bug
jameskoster
approved these changes
Aug 20, 2024
|
Pushed an update to the e2e test: the "sync" filter is no longer hidden, so we don't have to toggle the "filter button" to make it visible. |
|
Size Change: +163 B (+0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
7 tasks
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
WordPress#64651) Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #63203 (comment)
What?
If the screen has a primary filter, the "Filter toggle" loads as open.
Gravacao.do.ecra.2024-08-20.as.17.56.28.mov
Why?
Primary filters were created to give some filters higher visibility. This is still useful.
How?
When loading the component, consider whether there's any primary filter. If there is, load it opened.
Testing Instructions
Go to the Patterns page and verify the "Sync" filter is visible and that the user can still hide all filters: