DropdownMenuV2: use overloaded naming conventions #64654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
added
[Type] Enhancement
58 tasks
|
Size Change: -66 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Unfortunately, there seem to be some issues with Storybook:
I'd appreciate it if anyone had suggestions. |
|
The display names and docgen were fixed by 6968e74 (feel free to revert). Is it expected that Separator and Context show nothing in the props table? (Same in trunk) |
ciampo
force-pushed
the
feat/dropdown-menu-v2/overloaded-naming
branch
from
6968e74 to
2a7cb37
Compare
|
Thank you @mirka ! Storybook is looking good ✅
Yup that's expected |
|
Flaky tests detected in 88a1c54. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10489397387
|
ciampo
force-pushed
the
feat/dropdown-menu-v2/overloaded-naming
branch
from
8a0e174 to
88a1c54
Compare
ciampo
force-pushed
the
feat/dropdown-menu-v2/overloaded-naming
branch
from
88a1c54 to
8958f33
Compare
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
* Move subcomponents to overloaded syntax, rename to DropdownMenuV2 * Update imports and usage in Storybook * Update imports and usage in unit tests * Update README * Fix private APIs * Switch to overloaded naming in the rest of the project * Storybook story name typo * Try separate files * CHANGELOG * CHANGELOG: move to unreleased section --------- Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #50459
Apply overloaded naming conventions to
DropdownMenuV2Why?
To adhere to the later recommendations on how to name compound components
How?
Followed the suggested approach in the contributing guidelines, then updated all component usages.
Testing Instructions