Embed Block: Replace native input element with InputControl component #64668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Enhancement
12 tasks
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +143 B (+0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Aug 21, 2024
| className="components-placeholder__input" | ||
| aria-label={ label } | ||
| className="wp-block-embed__placeholder-input" | ||
| label={ __( 'Embed URL' ) } |
There was a problem hiding this comment.
Should this be __( 'Embed URL' ) or should it just be label?
There was a problem hiding this comment.
Good catch! I shouldn't have used a hard-coded string here. We should reference this label and display the corresponding label for the variation. I'll merge it after I update.
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
…WordPress#64668) * Embed Block: Replace native input element with InputControl component * Don't use hardcoded label Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41961
What?
This PR replaces the native input element with the
InputControlcomponent in the Embed block placeholder, and applies a new 40px size.Why?
In our current implementation, to apply the component styles we apply the
components-placeholder__inputclass directly, which is not ideal. Additionally, it doesn't allow us to apply the new 40px size.Testing Instructions
You should be able to embed the URL as before.
Screenshots or screencast