Post Title: Fix pasting in Safari #64671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
Size Change: -9 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 9738545. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10484875153
|
|
Thank you for this fix, @Mamaduka! 🎉 In my testing in Safari, this resolves the issue. Test ReportEnvironment
Actual Results
Supplemental Artifacts
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @Kuuuzya. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thanks for testing, @ironprogrammer! |
2 tasks
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
Unlinked contributors: lukasbesch, Kuuuzya. Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: ironprogrammer <ironprogrammer@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: murshed <fahimmurshed@git.wordpress.org> Co-authored-by: megane9988 <megane9988@git.wordpress.org> Co-authored-by: MatzeKitt <kittmedia@git.wordpress.org> Co-authored-by: marekzelezny <igreenie@git.wordpress.org>
|
Thanks @Mamaduka for the fix! It's awesome now! Two years of struggle are finally over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #51047.
PR fixes text pasting behavior for the post title component in Safari.
Why?
The deprecated
keypressevent, which fires beforepaste, resets the local selection state and makes itundefinedwhen pasting a value. This causes unexpected behavior in browsers that still support this event.P.S. You can reproduce the same behavior on Chrome by calling
onUnselectononKeyDown.How?
Remove the
onKeyPressevent handler. The event has been deprecated, and as far as I can tell, there is no actual use case for this component. It was initially introduced in #1042.Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2024-08-21.at.10.28.05.mp4