Data views: Update search appearance in narrow containers #64681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
jameskoster
requested review from
a team,
youknowriad,
oandregal and
jorgefilipecosta
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Can we mention this in the changelog. Let's make it a habit to document all the DataViews and DataForms changes in the changelog to make it easier for folks to upgrade and know exactly what changed. |
|
Size Change: -143 B (-0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
youknowriad
approved these changes
Aug 21, 2024
|
I think bulk actions are fine once #64268 is merged. I appreciate it will be tricky to make the quick edit panel work on mobile, but it seems a shame to remove the feature only for that reason. Quick edit seems just as valuable on mobile. An idea:
😓 |
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
…64681) Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Increase the width of the search field in narrow containers.
Why?
It's currently unnecessarily small.
How?
Adjusts the layout of
.dataviews__view-actionsso that the search container and the actions container are the only two children, split byjustify-content: space-between. This allows the search container to shrink / grow as needed.Testing Instructions