Block bindings: Lock editing in fields in editor if meta fields panel is opened. #64738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +622 B (+0.04%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
|
I like where it is heading. Thank you for opening this alternative PR. We will have to cross-check with #64570 that adds a new preference for enabling/disabling Block Bindings UI. |
|
Flaky tests detected in cc4009d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10698331292
|
I see that preference slightly different because they could be compatible. If we follow this approach, what would we want?
So I guess it is a matter of deciding if we want only the first option or both of them. First option seems enough for me, but I don't have a strong opinion. |
|
Apart from that, I like the approach. My main concern is that it solves the issue faced in block bindings but other plugins like this report will still face the same problem when they modify post meta through the store. Additionally, other external sources like ACF, Pods, or WooCommerce will probably need to replicate this logic. |
64 tasks
There was a problem hiding this comment.
I left a couple of small comments. Apart from that, the workflow from Unchecked->Checked feels a bit weird to me, although I don't have an idea for improvement right now.
It'd be great to get feedback from @WordPress/gutenberg-design to check what is the proper way of sharing this "warning".
| <CustomFieldsConfirmation willEnable={ isChecked } /> | ||
| ) } | ||
| </PreferenceBaseOption> | ||
| <> |
There was a problem hiding this comment.
I believe this extra wrapper is not needed, right?
There was a problem hiding this comment.
I tried different approaches and forgot to remove it. 😓
There was a problem hiding this comment.
Done in 754a174
| { isChecked && ( | ||
| <p className="edit-post-preferences-modal__custom-fields-confirmation-message"> | ||
| { __( | ||
| 'Connected attributes cannot be edited in the block editor while this interface is active.' |
There was a problem hiding this comment.
Should this be something like 'Custom fields connected to block attributes cannot be edited in the block editor while this interface is active.' or something similar?
Technically speaking, users aren't editing the attributes but the custom fields.
There was a problem hiding this comment.
Done in 754a174
cbravobernal
force-pushed
the
experiment/do-not-allow-editing-bindings-meta-fields-opened
branch
from
8a02ae7
to
754a174
Compare
| <p className="edit-post-preferences-modal__custom-fields-confirmation-message"> | ||
| { __( | ||
| 'Custom fields connected to block attributes cannot be edited in the block editor while this interface is active.' | ||
| ) } |
There was a problem hiding this comment.
For me, this wording is still hard to follow. How about a phrasing like this: "Enabling this interface will disable inline editing of custom fields."
The reason I say this: The meta fields panel is still part of the block editor too — at least, It appears that way to an end user. With that in mind, I think specifying 'inline editing' as becoming disabled is clearer.
Additionally, we can likely further simplify the message by removing the 'connected to block attributes' detail. Without the meta fields panel, it's only possible to edit custom fields in the editor when they're connected, right? So to me, specifying extra details around connections just makes the message verbose and difficult to understand.
There was a problem hiding this comment.
This is what I see:
The text is so long now that it might be difficult to notice that clicking the reload button is mandatory to activate the setting.
There was a problem hiding this comment.
I share similar concerns regarding the UX here. I'm in favor of simplifying the message or even looking for an alternative approach (but not sure what).
There was a problem hiding this comment.
No change to the message works for me, too. The UI will lock everything as in WordPress 6.5 which will be the clear indicator that it can't be edited inline. One potential enhancement to consider would be showing a prompt to disable Meta Boxes / Custom Fields interface if folks want to use the Attributes in the sidebar. This way, they could reload the page switch between modes. Not the best user experience, but it explains the story well.
There was a problem hiding this comment.
I'm fine removing the message as well. And we can figure out later if it is needed, or if the Attributes panel is a better place, based on feedback.
gziolo
approved these changes
Sep 4, 2024
cbravobernal
deleted the
experiment/do-not-allow-editing-bindings-meta-fields-opened
branch
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #64217
Following @gziolo proposal, let's try an experiment that locks editing if the meta fields panel is opened.
An alternative to #64505
Why?
Experimenting.
How?
Testing Instructions
Screenshots or screencast
Screen.Recording.2024-08-23.at.12.35.54.mov