REST API: Fix hacky block editor settings filter #64743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
[Type] Bug
swissspidy
requested review from
TimothyBJacobs,
spacedmonkey and
geriux
as code owners
swissspidy
force-pushed
the
fix/hacky-rest-api-code
branch
from
b74ae21
to
d87c657
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
spacedmonkey
approved these changes
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix
gutenberg_get_block_editor_settings_mobileandWP_REST_Block_Editor_Settings_Controllerto not rely on constants and superglobals.Why?
I wanted to work on some PHP stuff in another PR and realized that this hacky code breaks a lot of things because of side effects like defining
REST_REQUESTin a test file (not even within the class and in a separate process!)How?
Refactor these two places to not rely on
$_GET['context']ordefined( 'REST_REQUEST' )and do things the proper way.Testing Instructions
Block editor settings for mobile should still work the same.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A