Fluid typography: allow individual preset overrides #64790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ography is disabled or not active but an individual font preset does enable it, calculate the clamp value for that individual preset.
ramonjd
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
2 tasks
|
Size Change: -31 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
matiasbenedetto
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
This is testing well for me.
I tried the opt-in of particular font size presets when the global settings.typography.fluid isn't set and when it's set to false. In both cases the individual font size presets defined in the settings.typography.fontSizes array works as expected rendering the fluid CSS formula for the preset. I think this PR solved the inconsistency defined in #64766 so I think it's good to merge.
2 tasks
t-hamano
approved these changes
Aug 27, 2024
2 tasks
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
* This commit allows individual font preset overrides. So, if fluid typography is disabled or not active but an individual font preset does enable it, calculate the clamp value for that individual preset. Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #64766
What?
This PR allows individual font preset overrides.
So, if fluid typography is disabled or not active but an individual font preset does enable it, calculate the clamp value for that individual preset.
Why?
Individual font sizes may opt out of fluid typography if it is turned on globally.
This PR does the opposite: individual font size presets can opt in to fluid typography if it is not turned on globally.
How?
Check if fluid settings on individual font size presets are present.
Testing Instructions
"fluid": trueto the preset object. See the below example theme.json.Here is some test theme.json
{ "$schema": "https://schemas.wp.org/trunk/theme.json", "version": 3, "settings": { "typography": { "fontSizes": [ { "name": "Big bill", "size": "59px", "slug": "big-bill" }, { "name": "Medium Matt", "size": "30px", "slug": "med-matt", "fluid": true }, { "name": "Small Ted", "size": "1rem", "slug": "small-ted", "fluid": { "max": "60px", "min": "30px" } } ] } } }