Block Patterns List: Fix visual title and tooltip inconsistencies #64815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +14 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in a54ffc6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11755727831
|
t-hamano
force-pushed
the
block-patterns-list-unify-title
branch
from
79c12e9 to
973e4aa
Compare
t-hamano
added
[Type] Bug
t-hamano
commented
Aug 27, 2024
Comment on lines
72
to
78
| #### showTitle | ||
|
|
||
| Whether to show the block pattern title. User-defined patterns always show a title regardless of this prop. | ||
|
|
||
| - Type: `boolean` | ||
| - Required: No | ||
| - Default: true |
There was a problem hiding this comment.
Add missing documentation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @isuke01. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Why this exception? |
In this PR, I introduced a rule called "In modals, always show the visual title". As a result, it means that only the modal after creating a custom template did not follow this rule.
|
|
Thanks for the PR! I think what complicated things a bit more is the I didn't check thoroughly right now, but I'm wondering if the I'm all for consistency, but should we keep the initial |
t-hamano
force-pushed
the
block-patterns-list-unify-title
branch
from
973e4aa to
a54ffc6
Compare
|
Sorry for the late reply.
That's true. I've removed the BTW, this PR will also improve the Change Design popover:
|
t-hamano
added
[Focus] Accessibility (a11y)
ntsekouras
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64632
Related to #64166, #60160
What?
This PR resolves inconsistencies and introduces clearer rules for the title and tooltip in the
BlockPatternListcomponent.Why?
I think there are three problems with this component currently:
How?
In this PR, I apply the following rules wherever the
BlockPatternsListcomponent is used to resolve these inconsistencies:To achieve this, I removed the
showTitlesAsTooltipshowTitleprop from theBlockPatternsListcomponent. Whether or not to show a tooltip is determined solely by whether or not to show the visual title, i.e. theshowTitleshowTitleAsTooltipprop.I am also aware that in some places the visual title is intentionally hidden. One example is #60160. Respecting this approach, the visual titles remain unchanged in this PR, with one exception.
The only visual change in this PR is the modal after creating a custom template:
This is the result based on the rule "In modals, always show the visual title", but we can change the title "Fallback content" or make an exception and not display a visual title.
Testing Instructions
Check where the
BlockPatternsListcomponent is used and make sure there are no visual changes.Make sure that visual titles and tooltips are displayed based on the following rules:
Pattern inserter
Pattern inserter (mobile)
Template Parts Design panel
Explore all patterns modal
Template Parts replace modal
Main inserter > Search pattern
Query Loop block > Choose a pattern modal
Swap Template modal
After creating a custom template
After creating a new page
Transform a Query Loop block to a pattern