Fix: Impossible to see pagination on viewports between small and medium. #64844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -907 B (-0.05%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
t-hamano
reviewed
Aug 28, 2024
There was a problem hiding this comment.
I think the root cause is probably that height:100% is applied to the .edit-site-page element, which pushes the pagination down.
When the browser width is 600px or less, the pagination is certainly accessible, but double scrolling occurs and we cannot access it without manipulating the outer scrollbar:
daa2ef452f09c2432c5d94df2684b943.mp4
When the browser width is 600px or more, the .edit-site element is fixed in position, so the outer scrollbar disappears and pagination might become inaccessible.
The mobile layout may need to be adjusted overall in the future, but for now it seems to work fine if we subtract the height of the header from the height of the .edit-site-page element, and it also fixes the double scrollbar issue.
.edit-site-page {
height: calc(100% - #{$header-height});
@include break-medium() {
height: 100%;
}
}5ac61a42c6fc05ecd48de4c8f2ef98ab.mp4
Additionally, I discovered an issue with the floating bulk actions menu overlapping with pagination, but this should be resolved once #64268 ships:
…and medium." This reverts commit 5ef2631.
|
Good suggestion @t-hamano. I pushed that change, hope you don't mind @jorgefilipecosta. |
There was a problem hiding this comment.
Thank you @t-hamano and @jameskoster for this fix. Things seem to work well on the tests I did 👍
jorgefilipecosta
deleted the
fix/impossible-to-see-pagination-on-viewports-between-small-and-medium
branch
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
…um. (WordPress#64844) Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an already existing issue reported by @jameskoster at #64268 (comment). For viewports between 600 and 782, it is totally impossible to use the pagination on trunk.
Testing Instructions
I changed the window viewport size to 650px.
On a page with more than 10 items, I configured the view to 10 items per page.
I verified the pagination UI was available (on the trunk it is not).