Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Embed blocks: figcaption inserted via toolbar not nested within figure element - #64960 #64970

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

hbhalodia
Copy link
Contributor

What?

Why?

How?

  • PR refactors the embed block to use caption inside embed preview for editor, so that figcaption adds as a child of figure instead of sibling.

Testing Instructions

  1. Add embed block.
  2. Add the caption.
  3. Inspect the caption element, and you can see figcaption added as a child of figure.

Testing Instructions for Keyboard

  • NIL

Screenshots or screencast

GB-Issue-64960.mov

Copy link

github-actions bot commented Sep 2, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: hbhalodia <hbhalodia@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano self-requested a review September 10, 2024 05:48
@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Block] Embed Affects the Embed Block labels Sep 10, 2024
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works as expected 👍

@t-hamano t-hamano added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Sep 10, 2024
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Sep 10, 2024
@t-hamano t-hamano merged commit aca9273 into WordPress:trunk Sep 10, 2024
70 of 72 checks passed
@github-actions github-actions bot added this to the Gutenberg 19.3 milestone Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Embed Affects the Embed Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants