Try: Update block warnings. #64997
Merged
Try: Update block warnings. #64997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Note that I skipped some pre-commit hooks on this one, as I wasn't sure how to fix them and suspect they are related to my dev env, so would appreciate a gut-check. |
|
Size Change: -29 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
SantosGuillamot
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
I just came across these visual issues while testing alternatives for this other pull request.
Changes look good on my testing. Apart from the use cases explained in the description, secondary actions seem to work fine as well.
|
Thanks for the review! |
|
Nice fix. Small reminder that it's preferable not to merge PR's with 'Try' prefix in the title as it can give the wrong impression to anyone browsing commits. |
bph
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix visual glitches in the block error boundary. Before:
After:
Testing Instructions
Go to the code editor and insert the test code.
Test code
Now observe the result to have clearer prose, sentence case for actions, and improved margins/gaps.