Pattern Transformations Menu: do not use Composite store #65040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -21 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
ciampo
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tyxla
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
LGTM - works the same as in trunk 👍
I did spot something that feels off though (it's the same in trunk, so this PR can be merged):
- Insert a "Query Loop" block
- Click the transform button
- Use the keyboard to navigate to "Patterns" (arrow up/down for up/down, space to select)
- Verify arrow up/down works for changing the selected pattern.
- Try shift+tab or esc, but you won't be able to get away of that view or go back to the transform menu. This feels off.
ciampo
deleted the
feat/stabilize-composite/no-store/pattern-transformations-menu
branch
Yeah, I think that's because that piece of UI is not actually using a It should get better once we refactor it to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Extracted from #64723
Do not use Composite's store directly in Pattern Transformations Menu
Why?
See #63704 (comment)
How?
We recently made changes so that:
Compositecomponent accepts the same props asuseCompositeStore;Compositesubcomponents already receive the correctstorewithout need for the consumer to pass it explicitlyTherefore, we can migrate from
to
Testing Instructions
trunk— ie. it is one tab stop, and using arrow keys moves the focus on the other list itemsScreenshots or screencast
Kapture.2024-09-04.at.11.45.00.mp4